Add conditional read after write for rules #584
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: Rebased from main after refactor in #13014 Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
…ch request Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Updated & added tests Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
4 tasks
| for i, rule := range g.rules { | ||
| select { | ||
| case <-g.done: | ||
| return | ||
| default: | ||
| } | ||
|
|
||
| func(i int, rule Rule) { | ||
| eval := func(i int, rule Rule, independent, async bool) { |
There was a problem hiding this comment.
instead of propagating this all the way way down and modifying a couple of interfaces, can't we just move NewOriginContext(ctx, NewRuleDetail(rule, independent)) from the rule to g.Eval (i.e. this function)?
Comment on lines
+32
to
+33
| // Independent holds whether this rule depends on the result of other rules | ||
| // within the same rule group or not. |
There was a problem hiding this comment.
this forgets to mention that if other rules depend on this rule Independent is also true
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
RuleDetail.IndependentRuleConcurrencyControllerintoRuleConcurrencyControllerandRuleDependencyController